Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Enable HTTPS on distributed components #2087

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 9, 2024

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Continue the feat simplify to enable HTTPS/TLS in Selenium Grid on Kubernetes

Motivation and Context

  • When --set isolateComponents=true, the Router could not be up due to wait for startup probe on API /readyz - this is fixed on upstream [java] Schema HTTPS in Distributor, SessionQueue, SessionMap selenium#13413 and will be released in 4.17.0
  • On the Node registration secret, the option --registration-secret needs to be added to SessionQueue, otherwise, the client gets error 401, secret doesn't match.
  • Add tests, docs if needed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96 VietND96 self-assigned this Jan 9, 2024
@VietND96 VietND96 marked this pull request as ready for review January 10, 2024 02:44
@VietND96 VietND96 merged commit 0a8e23d into SeleniumHQ:trunk Jan 10, 2024
7 checks passed
@VietND96 VietND96 deleted the https branch January 10, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant