-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Implementation of event wrapped shadow root element #12073
Conversation
I understand the complexity of setting the environment when space is limited. I can help to test the PR on my local Windows machine. In addition, I am checking GitHub Codespaces to see if it is possible to have a cloud environment for Windows. |
I postponed OS re-installation. In scope of this PR I need to create new unit tests to cover functionality. This is why PR is draft. I quickly looked through code, and it promising operational. In any case unit tests are required here. |
Created new unit tests, this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @nvborisenko!
Failures are not related to this PR, we need to check them apart.
Description
Raises events for web elements under shadow root.
Motivation and Context
Fixes #12049
Types of changes
Checklist
Note:
This is draft. I am out of disk space even to build solution. Bazel took 10GBs, Git repo 3GB (excluding preinstalled dependencies), and this is just to build 30MB nuget package. I will migrate from 256GB ssd to 1TB ssd, and in any case I will never install selenium dev dependencies on my system drive, shortly saying selenium dev environment will be isolated in VM.