Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: EventFiringWebDriver doesn't wrap ShadowRoot instance #12049

Closed
mcichonqa opened this issue May 16, 2023 · 6 comments · Fixed by #12073
Closed

[🐛 Bug]: EventFiringWebDriver doesn't wrap ShadowRoot instance #12049

mcichonqa opened this issue May 16, 2023 · 6 comments · Fixed by #12073
Labels
C-dotnet help wanted Issues looking for contributions I-defect

Comments

@mcichonqa
Copy link

What happened?

Im using EventFiringWebDriver instance for invoke some events like a listeners and all was very good until the moment when I got ShadowRoot instance. When I used GetShadowRoot().FindElement() returned instance is without any events so if some elements nested in shadow root cause some problems I will not see that.

Is there any way to achive these events inside shadow root element? Im not seeing similar class like EventFiringWebElement for wrap ShadowRoot.

How can we reproduce the issue?

IWebDriver searchContext = new EventFiringWebDriver(driver);
IWebElement parentElement = searchContext.FindElement(locator for parent element); <--- This will return EventFiringWebElement

ShadowRoot shadowRoot = parentElement.GetShadowRoot();
shadowRoot.FindElement(locator for child element); <--- This will return WebElement instance, but I expected something like EventFiringShadowRoot instance including events

Relevant log output

Empty

Operating System

Windows10

Selenium version

4.8.2

What are the browser(s) and version(s) where you see this issue?

Chrome 113.0.5672.93

What are the browser driver(s) and version(s) where you see this issue?

ChromeDriver 113.0.5672.6300

Are you using Selenium Grid?

Tested without RemoteWebDriver

@github-actions
Copy link

@mcichonqa, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented May 17, 2023

Unless I am missing something, I believe this was not added when shadow DOM landed.

@diemol diemol added the help wanted Issues looking for contributions label May 17, 2023
@github-actions
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@nvborisenko
Copy link
Member

I will try to fix it while I have bazel installed.

@mcichonqa
Copy link
Author

Thanks :)

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-dotnet help wanted Issues looking for contributions I-defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants