Feat: Expose ping method from SQLx #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
reviewed
May 3, 2023
tyt2y3
reviewed
May 15, 2023
|
@tyt2y3 please check again |
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
tyt2y3
approved these changes
Jun 1, 2023
|
Sorry, my poor internet again. And seemingly there isn't a debounce. |
darkmmon
added a commit
to darkmmon/seaql.github.io
that referenced
this pull request
Jul 12, 2023
billy1624
added a commit
to SeaQL/seaql.github.io
that referenced
this pull request
Jul 19, 2023
* Optional Field SeaQL/sea-orm#1513 * .gitignore SeaQL/sea-orm#1334 * migration table custom name SeaQL/sea-orm#1511 * OR condition relation SeaQL/sea-orm#1433 * DerivePartialModel SeaQL/sea-orm#1597 * space for migration file naming SeaQL/sea-orm#1570 * composite key up to 12 SeaQL/sea-orm#1508 * seaography integration SeaQL/sea-orm#1599 * QuerySelect SimpleExpr SeaQL/sea-orm#1702 * sqlErr SeaQL/sea-orm#1707 * migration check SeaQL/sea-orm#1519 * postgres array SeaQL/sea-orm#1565 * param intoString SeaQL/sea-orm#1439 * **skipped** re-export SeaQL/sea-orm#1661 * ping SeaQL/sea-orm#1627 * on empty do nothing SeaQL/sea-orm#1708 * on conflict do nothing SeaQL/sea-orm#1712 * **skipped** upgrade versions * active enum fail safe SeaQL/sea-orm#1374 * relation generation check SeaQL/sea-orm#1435 * entity generation bug SeaQL/sea-schema#105 * **skipped** bug fix that does not require edits * EnumIter change SeaQL/sea-orm#1535 * completed and fixed a previous todo SeaQL/sea-orm#1570 * amended wordings and structures * Edit * Remove temp file --------- Co-authored-by: Billy Chan <[email protected]>
🎉 Released In 0.12.1 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
New Features
async fn ping(&self) -> Result<(), DbErr>toDatabaseConnectionasync fn ping(&self) -> Result<(), DbErr>toDatabaseTransactionMore
Thoses methods are only wrappers for sqlx::Connection::ping as asked in the issue
It's my first PR on this repo so any feedback is welcomed !
Thanks you for reading