Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ping method from SQLx #1578

Closed
wojciechbator opened this issue Apr 4, 2023 · 1 comment · Fixed by #1627
Closed

Expose ping method from SQLx #1578

wojciechbator opened this issue Apr 4, 2023 · 1 comment · Fixed by #1627
Assignees
@ProbablyClem

Comments

@wojciechbator
Copy link

Motivation

Currently, when doing a DB probe check, I need to write a simple SELECT 1 query. This logs query to otel and currently it's impossible to turn off logging on query level. Exposing ping method that is a simplest, internal healthcheck method would simplify and streamline this process a lot.

Proposed Solutions

Wrap over SQLx ping method in your way. #291 (reply in thread)

Current Workarounds

Query written by hand, that spams logs.
@ProbablyClem
Copy link
Contributor

Hey, i'd gladly take a look at it as it seems to be a good first contribution !

@ProbablyClem ProbablyClem mentioned this issue May 1, 2023
Merged
2 tasks
@billy1624 billy1624 moved this from Triage to In Progress in SeaQL Dev Tracker May 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in SeaQL Dev Tracker Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProbablyClem ProbablyClem

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Expose ping method from SQLx ProbablyClem/sea-orm
2 participants
@wojciechbator @ProbablyClem