Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only lint the list items #7

Closed
wants to merge 1 commit into from

Conversation

chinesedfan
Copy link

Fix sindresorhus/awesome-lint#133.

  • main logic to find list items keeps the same with awesome-lint/rules/list-item.js
  • fix a typo in tests
  • BREAKING update tests to ignore double-links not in list items

@Scrum
Copy link
Owner

Scrum commented Jan 21, 2021

@chinesedfan Hi thanks for your PR.

I've looked at this PR for a long time and I still can't figure out why we shouldn't check the links in the paragraph and the link description?

I believe that if there are more than one links, then it already looks like a repository pair. The link or paragraph should contain a general description that characterizes the package.

@chinesedfan
Copy link
Author

@Scrum Hi, the linked sindresorhus/awesome-lint#133 may remind you of something. If have read it and changed your mind, you can reply there and close this PR.

@Scrum Scrum closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubt about awesome-lint double-link error
2 participants