Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt about awesome-lint double-link error #133

Open
niedev opened this issue Nov 10, 2020 · 6 comments
Open

Doubt about awesome-lint double-link error #133

niedev opened this issue Nov 10, 2020 · 6 comments

Comments

@niedev
Copy link
Contributor

niedev commented Nov 10, 2020

If the double links are in the description of two different elements (because they both are a fork of the linked repository) is this still considered an error? as if I didn't respect the guidelines?

@sindresorhus sindresorhus transferred this issue from sindresorhus/awesome Nov 20, 2020
@sindresorhus
Copy link
Owner

I think we should only lint the list items for double links. Not their description, and not any other text.

// @Scrum

@Scrum
Copy link
Contributor

Scrum commented Nov 23, 2020

If the double links are in the description of two different elements (because they both are a fork of the linked repository) is this still considered an error? as if I didn't respect the guidelines?

Only links are checked, describe your problem in more detail

@niedev
Copy link
Contributor Author

niedev commented Nov 24, 2020

For example, if I have these two elements in the readme:

Awesome-lint will notify double-link error for the Launcher3 links in the descriptions.

@Scrum
Copy link
Contributor

Scrum commented Jan 21, 2021

I still can't figure out why we shouldn't check the links in the paragraph and the link description?

I believe that if there are more than one links, then it already looks like a repository pair. The link or paragraph should contain a general description that characterizes the package.

@morinted
Copy link
Contributor

morinted commented Apr 9, 2021

My false positive for this rule came from my preamble, where I linked to the project by its [name](github.com/project/name) and in the link given on the logo, which was recommended in the awesome-list guidelines.

@wongyah
Copy link

wongyah commented Apr 17, 2024

I got the same error (double links) because of the links in item descriptions and connecting paragraphs.

I deleted all these kinds of links now to compliant with the awesome-lint rules, but I think I paid the price of readability. I will add these links back when the bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants