Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mailing note #963

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Fix mailing note #963

merged 4 commits into from
Mar 1, 2022

Conversation

talavis
Copy link
Contributor

@talavis talavis commented Mar 1, 2022

Should fix the logic for notification about an email being sent.

Not tested in CLI.

Closes #957.

  • Tests passing
  • Black formatting
  • [-] Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #963 (5de9a5c) into dev (938751b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5de9a5c differs from pull request most recent head d66fe74. Consider uploading reports for the commit d66fe74 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #963      +/-   ##
==========================================
- Coverage   87.92%   87.91%   -0.02%     
==========================================
  Files          26       26              
  Lines        2899     2895       -4     
==========================================
- Hits         2549     2545       -4     
  Misses        350      350              
Impacted Files Coverage Δ
dds_web/api/user.py 87.56% <100.00%> (+0.03%) ⬆️
dds_web/api/dds_decorators.py 83.52% <0.00%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 938751b...d66fe74. Read the comment docs.

@talavis talavis requested a review from i-oden March 1, 2022 14:10
@talavis talavis self-assigned this Mar 1, 2022
@i-oden i-oden added bug Something isn't working must have Cannot deliver on target date without this labels Mar 1, 2022
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this fixed it!

@i-oden i-oden merged commit 674ab57 into dev Mar 1, 2022
@i-oden i-oden deleted the fix-mailing-note branch March 1, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must have Cannot deliver on target date without this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No message that the email hasn't been sent - incorrect informtion
2 participants