Merge branch 'dev' into fix-mailing-note

CHANGELOG.md

@@ -29,3 +29,4 @@ Please add a _short_ line describing the PR you make, if the PR implements a spe
 * Add support for getting IPs from X-Forwarded-For ([#952](https://github.com/ScilifelabDataCentre/dds_web/pull/952))
 * Relax requirements for usernames (wider length range, `.` and `-`) ([#943](https://github.com/ScilifelabDataCentre/dds_web/pull/943))
 * Fix logic for notification about sent email ([#963])(https://github.com/ScilifelabDataCentre/dds_web/pull/963))
+* Extended the `dds_web.api.dds_decorators.logging_bind_request` decorator to catch all not yet caught exceptions and make sure they will be logged ([#958](https://github.com/ScilifelabDataCentre/dds_web/pull/958)).

dds_web/api/dds_decorators.py

@@ -21,6 +21,7 @@
     BucketNotFoundError,
     DatabaseError,
     DDSArgumentError,
+    LoggedHTTPException,
     NoSuchUserError,
     AccessDeniedError,
     MissingJsonError,
@@ -155,15 +156,25 @@ def wrapper_logging_bind_request(*args, **kwargs):
             project=flask.request.args.get("project") if flask.request.args else None,
             user=get_username_or_request_ip(),
         ):
-            value = func(*args, **kwargs)
 
-            if hasattr(value, "status"):
-                structlog.threadlocal.bind_threadlocal(response=value.status)
-
-            action_logger.info(f"{flask.request.endpoint}.{func.__name__}")
-
-            # make sure the threadlocal state is pruned after the log was written.
-            structlog.threadlocal.clear_threadlocal()
-            return value
+            try:
+                value = func(*args, **kwargs)
+
+                if hasattr(value, "status"):
+                    structlog.threadlocal.bind_threadlocal(response=value.status)
+
+                action_logger.info(f"{flask.request.endpoint}.{func.__name__}")
+                # make sure the threadlocal state is pruned after the log was written.
+                structlog.threadlocal.clear_threadlocal()
+                return value
+
+            except Exception as err:
+                if not isinstance(err, LoggedHTTPException):
+                    # HTTPExceptions are already logged as warnings, no need to log twice.
+                    action_logger.exception(
+                        f"Uncaught exception in {flask.request.endpoint}.{func.__name__}",
+                        stack_info=True,
+                    )
+                raise
 
     return wrapper_logging_bind_request