Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for flow from invite to access of project private #912

Conversation

alneberg
Copy link
Contributor

@alneberg alneberg commented Feb 18, 2022

... and fixed the final little piece for inviting researchers.

Before submitting a pr:

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@alneberg alneberg mentioned this pull request Feb 18, 2022
5 tasks
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #912 (a62c39c) into invite-researchers (3bd7102) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           invite-researchers     #912      +/-   ##
======================================================
+ Coverage               85.92%   86.18%   +0.26%     
======================================================
  Files                      26       26              
  Lines                    2800     2795       -5     
======================================================
+ Hits                     2406     2409       +3     
+ Misses                    394      386       -8     
Impacted Files Coverage Δ
dds_web/api/user.py 88.28% <ø> (ø)
dds_web/security/auth.py 98.11% <0.00%> (+1.16%) ⬆️
dds_web/api/schemas/user_schemas.py 89.41% <0.00%> (+7.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd7102...a62c39c. Read the comment docs.

@i-oden i-oden merged commit 6fdbacb into ScilifelabDataCentre:invite-researchers Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants