Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for invites #907

Closed
wants to merge 10 commits into from
Closed

Conversation

alneberg
Copy link
Contributor

Will try to add tests for invites that cover all the regular use cases. Opened a PR mostly to show/track progress.

Before submitting a pr:

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@alneberg alneberg changed the title Fix invites Fix tests for invites Feb 18, 2022
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #907 (9a00609) into dev (aded197) will not change coverage.
The diff coverage is n/a.

❗ Current head 9a00609 differs from pull request most recent head 3099cd1. Consider uploading reports for the commit 3099cd1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #907   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          26       26           
  Lines        2812     2812           
=======================================
  Hits         2422     2422           
  Misses        390      390           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aded197...3099cd1. Read the comment docs.

@i-oden i-oden added the should have Important but not vital label Feb 18, 2022
@alneberg
Copy link
Contributor Author

Closing since #912 has taken its place.

@alneberg alneberg closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
should have Important but not vital
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants