Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite researchers to projects #911

Merged
merged 32 commits into from
Feb 19, 2022
Merged

Invite researchers to projects #911

merged 32 commits into from
Feb 19, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Feb 18, 2022

Before submitting a pr:

  • Tests passing
  • Black formatting
  • Migrations for any changes to the database schema
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

@i-oden i-oden requested a review from alneberg February 18, 2022 15:14
@i-oden i-oden self-assigned this Feb 18, 2022
@i-oden i-oden changed the title Invite researchers Invite researchers to projects Feb 18, 2022
@i-oden i-oden mentioned this pull request Feb 18, 2022
5 tasks
dds_web/api/user.py Outdated Show resolved Hide resolved
dds_web/api/user.py Outdated Show resolved Hide resolved
Copy link
Contributor

@worukan worukan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #911 (6fdbacb) into dev (aded197) will increase coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #911      +/-   ##
==========================================
+ Coverage   86.13%   86.14%   +0.01%     
==========================================
  Files          26       26              
  Lines        2812     2800      -12     
==========================================
- Hits         2422     2412      -10     
+ Misses        390      388       -2     
Impacted Files Coverage Δ
dds_web/api/project.py 93.18% <ø> (ø)
dds_web/database/models.py 94.24% <ø> (-0.14%) ⬇️
dds_web/api/user.py 88.28% <84.78%> (-1.36%) ⬇️
dds_web/api/schemas/user_schemas.py 89.41% <85.71%> (+6.84%) ⬆️
dds_web/errors.py 82.14% <100.00%> (+0.10%) ⬆️
dds_web/security/project_user_keys.py 97.36% <100.00%> (ø)
dds_web/utils.py 76.92% <100.00%> (+0.25%) ⬆️
dds_web/security/auth.py 96.95% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aded197...6fdbacb. Read the comment docs.

@i-oden i-oden linked an issue Feb 18, 2022 that may be closed by this pull request
@i-oden i-oden added the must have Cannot deliver on target date without this label Feb 19, 2022
@i-oden i-oden merged commit d90abdd into dev Feb 19, 2022
@i-oden i-oden deleted the invite-researchers branch February 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must have Cannot deliver on target date without this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add researchuser to project during registration
3 participants