Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ls and deactivate subcommands to dds motd and displaying of multiple active motds #1212

Merged
merged 15 commits into from
Aug 4, 2022

Conversation

valyo
Copy link
Member

@valyo valyo commented Jun 30, 2022

Adds ls and deactivate subcommands to dds motd
and displaying of multiple active motds
works with ScilifelabDataCentre/dds_cli#505

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Changes to the database schema: A new migration is included in the PR

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1212 (d2f5dda) into dev (8dfdfd9) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1212      +/-   ##
==========================================
+ Coverage   86.05%   86.13%   +0.07%     
==========================================
  Files          29       29              
  Lines        3686     3707      +21     
==========================================
+ Hits         3172     3193      +21     
  Misses        514      514              
Impacted Files Coverage Δ
dds_web/__init__.py 59.36% <100.00%> (ø)
dds_web/api/superadmin_only.py 100.00% <100.00%> (ø)
dds_web/database/models.py 94.58% <100.00%> (+0.01%) ⬆️
dds_web/utils.py 96.90% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden marked this pull request as ready for review August 2, 2022 07:08
@i-oden
Copy link
Member

i-oden commented Aug 4, 2022

@valyo Would you like to have a look again before I merge or are you satisfied?

@valyo
Copy link
Member Author

valyo commented Aug 4, 2022

Looks good, if you don't want me to explicitly test it, then go on and merge 👍

@i-oden
Copy link
Member

i-oden commented Aug 4, 2022

Looks good, if you don't want me to explicitly test it, then go on and merge +1

Great! Nah you've added the tests and I've also tried it out.

@i-oden i-oden merged commit b400349 into dev Aug 4, 2022
@i-oden i-oden deleted the multiple_motds branch August 8, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants