Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple motds in CLI and deactivate old ones #505

Merged
merged 18 commits into from
Aug 5, 2022
Merged

Conversation

valyo
Copy link
Member

@valyo valyo commented Jun 30, 2022

Adds ls and deactivate subcommands to dds motd
and displaying of multiple active motds
works with ScilifelabDataCentre/dds_web#1212

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes DDS-1305

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

dds_cli/motd_manager.py Outdated Show resolved Hide resolved
dds_cli/motd_manager.py Outdated Show resolved Hide resolved
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match the suggested change in the web part

dds_cli/motd_manager.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #505 (8e18e21) into dev (9a95133) will increase coverage by 0.70%.
The diff coverage is 65.90%.

@@            Coverage Diff             @@
##              dev     #505      +/-   ##
==========================================
+ Coverage   41.44%   42.15%   +0.70%     
==========================================
  Files          29       29              
  Lines        2531     2567      +36     
==========================================
+ Hits         1049     1082      +33     
- Misses       1482     1485       +3     
Impacted Files Coverage Δ
dds_cli/__main__.py 41.04% <40.00%> (-0.37%) ⬇️
dds_cli/motd_manager.py 100.00% <100.00%> (+25.00%) ⬆️
dds_cli/base.py 44.08% <0.00%> (+1.07%) ⬆️
dds_cli/exceptions.py 89.13% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden
Copy link
Member

i-oden commented Aug 4, 2022

@valyo Ok to merge this too? I altered it slightly in the beginning of the week.

@valyo
Copy link
Member Author

valyo commented Aug 4, 2022

@valyo Ok to merge this too? I altered it slightly in the beginning of the week.

sure, I already saw the changes

@i-oden i-oden merged commit 40ae05d into dev Aug 5, 2022
@i-oden i-oden deleted the multiple_motds branch August 5, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants