Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #645

Merged
merged 59 commits into from
Aug 28, 2023
Merged

New release #645

merged 59 commits into from
Aug 28, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 28, 2023

Before submitting this PR

  1. Description: Merge before new CLI release.
  2. Jira task / GitHub issue: DDS-1631
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: If used with an older version of the API, using dds user ls --save-emails will result in a 404.
    • Non-breaking
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Pylint: Python code linter. Does not execute. Only tests.
    Fix code producing warnings. Code must get 10/10.
    • Warnings fixed
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #645 (1a357cc) into master (cbb5058) will increase coverage by 0.42%.
The diff coverage is 91.66%.

❗ Current head 1a357cc differs from pull request most recent head abd0845. Consider uploading reports for the commit abd0845 to get more accurate results

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   45.98%   46.41%   +0.42%     
==========================================
  Files          31       31              
  Lines        2766     2786      +20     
==========================================
+ Hits         1272     1293      +21     
+ Misses       1494     1493       -1     
Files Changed Coverage Δ
dds_cli/__main__.py 41.97% <50.00%> (+0.40%) ⬆️
dds_cli/__init__.py 91.66% <100.00%> (+0.10%) ⬆️
dds_cli/account_manager.py 40.59% <100.00%> (+11.18%) ⬆️
dds_cli/file_encryptor.py 52.84% <100.00%> (ø)
dds_cli/utils.py 97.40% <100.00%> (ø)
dds_cli/version.py 100.00% <100.00%> (ø)

@i-oden i-oden requested a review from valyo August 28, 2023 09:30
@i-oden i-oden marked this pull request as ready for review August 28, 2023 09:30
@i-oden i-oden marked this pull request as draft August 28, 2023 09:30
@i-oden i-oden marked this pull request as ready for review August 28, 2023 09:49
@i-oden i-oden merged commit 7dfc0d8 into master Aug 28, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants