Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography to 41.0.3 #639

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Bump cryptography to 41.0.3 #639

merged 4 commits into from
Aug 8, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 3, 2023

Before submitting this PR

  1. Description: Bumping cryptography package due to vulnerability
  2. Jira task / GitHub issue: https://github.com/ScilifelabDataCentre/dds_cli/security/dependabot/11
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Pylint: Python code linter. Does not execute. Only tests.
    Fix code producing warnings. Code must get 10/10.
    • Warnings fixed
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Aug 3, 2023
@i-oden i-oden marked this pull request as draft August 3, 2023 12:48
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #639 (3107272) into dev (10f0c2c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #639   +/-   ##
=======================================
  Coverage   46.09%   46.09%           
=======================================
  Files          31       31           
  Lines        2766     2766           
=======================================
  Hits         1275     1275           
  Misses       1491     1491           
Files Changed Coverage Δ
dds_cli/file_encryptor.py 52.84% <100.00%> (ø)

@i-oden i-oden requested a review from valyo August 8, 2023 06:16
@i-oden i-oden marked this pull request as ready for review August 8, 2023 06:17
Copy link
Member

@valyo valyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things seem to work, and I didn't get any issues. I checked the changelog of cryptography and it looks like we shouldn't be affected by the BACKWARDS INCOMPATIBLE changes, but I am not at all sure about this.

@i-oden i-oden merged commit 902993f into dev Aug 8, 2023
17 checks passed
@i-oden i-oden deleted the bump-cryptography branch August 8, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants