Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple motds and spinner while getting private key #511

Merged
merged 24 commits into from
Aug 8, 2022
Merged

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Aug 8, 2022

Description

Please include the following in this section

  • Summary of the changes and the related issue
  • Relevant motivation and context
  • Any dependencies that are required for this change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • Any dependent changes have been merged and published in downstream modules
  • Rebase/merge the branch which this PR is made to
  • Product Owner / Scrum Master: This PR is made to the master branch and I have updated the version

Formatting and documentation

  • I have added a row in the changelog
  • The code follows the style guidelines of this project: Black / Prettier formatting
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@i-oden i-oden self-assigned this Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #511 (d1b1c86) into master (39ff0d9) will increase coverage by 0.63%.
The diff coverage is 58.18%.

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   41.44%   42.08%   +0.63%     
==========================================
  Files          29       29              
  Lines        2531     2576      +45     
==========================================
+ Hits         1049     1084      +35     
- Misses       1482     1492      +10     
Impacted Files Coverage Δ
dds_cli/base.py 42.15% <20.00%> (-0.86%) ⬇️
dds_cli/__main__.py 41.04% <40.00%> (-0.37%) ⬇️
dds_cli/motd_manager.py 100.00% <100.00%> (+25.00%) ⬆️
dds_cli/version.py 100.00% <100.00%> (ø)
dds_cli/exceptions.py 89.13% <0.00%> (+8.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden added bug Something isn't working enhancement New feature or request labels Aug 8, 2022
@i-oden i-oden merged commit 2862560 into master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants