-
Notifications
You must be signed in to change notification settings - Fork 300
Bugfix array equality #6665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix array equality #6665
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3.12.x #6665 +/- ##
===========================================
- Coverage 89.80% 89.80% -0.01%
===========================================
Files 90 90
Lines 23752 23770 +18
Branches 4418 4419 +1
===========================================
+ Hits 21331 21346 +15
- Misses 1672 1678 +6
+ Partials 749 746 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…uding helpful errors.
…opriate for patch release.
HGWright
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval pending the completion of the benchmarks, and requires there to be no major slowdowns.
|
Benchmark Report Action Failed so here are the results. ⏱️ Performance Benchmark Report: 00e8b66Performance shiftsFull benchmark resultsGenerated by GHA run |
Elementwise comparison is no longer permitted when NumPy shapes cannot be broadcast (I need to find an official reference for this).
Much of Iris is already protected behind various
array_equalcalls, this PR mops up the remaining ones.Targetting
v3.12.xas this is required as an urgent bugfix for some users of Iris 3.12. Can propagate afterwards as necessary.