Temporary Nox negation pin - see wntrblm/nox#961 #6441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
benchmark_this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6441 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 90 90
Lines 23752 23752
Branches 4418 4418
=======================================
Hits 21331 21331
Misses 1672 1672
Partials 749 749 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ESadek-MO
approved these changes
May 2, 2025
Contributor
ESadek-MO
left a comment
ESadek-MO
left a comment
There was a problem hiding this comment.
LGTM! I think this is the right approach, we can sort lockfiles later if needs be.
Contributor
⏱️ Performance Benchmark Report: 993b27cPerformance shiftsFull benchmark resultsGenerated by GHA run |
Contributor
⏱️ Performance Benchmark Report: 993b27cPerformance shiftsFull benchmark resultsGenerated by GHA run |
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Aug 21, 2025
HGWright
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Protect _constraints from elementwise equality. * Protect cube.py from elementwise equality. * Fix dumb Constraint eq mistake. * Protect util from elementwise equality. * Correct return type for masked_array_equal. * Protect _structured_array_identitication from elementwise equality. * Fixes for saver.py * Protect pp.py from elementwise equality. * Protect pp_load_rules from elementwise equality. * Revert "Protect pp.py from elementwise equality." This reverts commit 864f0d7. * Protect _concatenate from elementwise NOT equality. * Protect _constraints from elementwise NOT equality. * Protect coords.py from elementwise NOT equality. * Protect cube.py from elementwise NOT equality. * Protect util from elementwise NOT equality. * Add structured array test for NumPy elementwise broadcasting error. * Extra updates for pp_load_rules.py * What's New entry. * Expose users to array comparison errors when requested directly, including helpful errors. * Back out new support for NumPy arrays in AttributeConstraint - inappropriate for patch release. * Revert change to intersection edge_wrap - will never be comparing 2 arrays. * Add test coverage for structured array eq with incompatible shapes. * Test coverage for broadcasting errors in pp_load_rules. * Common code for comparing attributes in case np arrays. * Temporary fix for TestLicenseHeaders. * Don't create a file when testing describe_diff. * Final tests for attribute comparison. * Fix any versus all confusion. * Temporary Nox negation pin - see wntrblm/nox#961. (#6441) --------- Co-authored-by: ukmo-ccbunney <christopher.bunney@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
The new PRs raised on the Nox GitHub suggest that this will be fixed in the next release of Nox.
The correct thing to do would be to update our dependencies and our lock files. Unfortunately we are half way through fixing a separate lock file problem (#6438) so I felt the pragmatic thing to do was only unblock the failing CI and nothing else.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: