Add castable check for valid_range, valid_min, valid_max
#6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6343 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 90 90
Lines 23523 23523
Branches 4390 4390
=======================================
Hits 21118 21118
Misses 1662 1662
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ukmo-ccbunney
approved these changes
Feb 28, 2025
Contributor
ukmo-ccbunney
left a comment
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Change and tests look good to me 👍
LGTM.
Contributor
Author
|
Thanks @ukmo-ccbunney! |
ukmo-ccbunney
added a commit
to ukmo-ccbunney/iris
that referenced
this pull request
Feb 28, 2025
* upstream/main: Faster dimension lookup for derived coordinates (SciTools#6337) Unpin dask 2 (SciTools#6342) added classification enums to qp (SciTools#6346) Add castable check for valid_range, valid_min, valid_max. (SciTools#6343) Pin Sphinx below 8.2 (SciTools#6344) Add a text feature to quickplot (SciTools#6333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Closes #6178
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: