-
Notifications
You must be signed in to change notification settings - Fork 300
Unpin dask 2 #6342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin dask 2 #6342
Conversation
# Conflicts: # requirements/locks/py313-linux-64.lock
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
⏱️ Performance Benchmark Report: cb2e13aPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 01d8a48Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 13438e9Performance shiftsFull benchmark resultsGenerated by GHA run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6342 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 90 90
Lines 23548 23548
Branches 4391 4391
=======================================
Hits 21143 21143
Misses 1662 1662
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
⏱️ Performance Benchmark Report: 3240223Performance shiftsFull benchmark resultsGenerated by GHA run |
# Conflicts: # requirements/locks/py311-linux-64.lock # requirements/locks/py312-linux-64.lock # requirements/locks/py313-linux-64.lock
⏱️ Performance Benchmark Report: ff2b196Performance shiftsFull benchmark resultsGenerated by GHA run |
ESadek-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with all the changes, tests seem to work as they used to (as a bonus, is more readable in places too).
Only thing left is I think it might be worth mentioning this is the dependencies whatsnew, as the pin was mentioned there originally.
⏱️ Performance Benchmark Report: 7bd7d0cPerformance shiftsFull benchmark resultsGenerated by GHA run |
* upstream/main: Faster dimension lookup for derived coordinates (SciTools#6337) Unpin dask 2 (SciTools#6342) added classification enums to qp (SciTools#6346) Add castable check for valid_range, valid_min, valid_max. (SciTools#6343) Pin Sphinx below 8.2 (SciTools#6344) Add a text feature to quickplot (SciTools#6333)
Completes #6312.