Skip to content

Conversation

@trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Ran into this problem when testing - benchmarks didn't trigger despite being labelled (#5772).

Logic dictates that we should test this, given the previous problem, but I don't know how that can be achieved given we need the App which is only on SciTools. I might try using pull_request instead of pull_request_target, in case the App gets round some of the other permissions...


Consult Iris pull request check list

@github-actions github-actions bot added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Feb 22, 2024
@trexfeathers
Copy link
Contributor Author

Looking at other examples, the label needs to be added by scitools-ci, not github-actions.

@codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8998779) 89.74% compared to head (6389477) 89.74%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5773   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          92       92           
  Lines       22940    22940           
  Branches     5462     5462           
=======================================
  Hits        20588    20588           
  Misses       1620     1620           
  Partials      732      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers
Copy link
Contributor Author

I don't think this a go-er, based on the fact that others haven't been able to get it working with pull requests, and that peter-evans/create-pull-request has been designed with this problem in mind, so may be working in a more sophisticated way that perhaps doesn't work for other actions.

I reckon it's SciTools/workflows#28 or bust

@trexfeathers trexfeathers deleted the label_locks_2 branch May 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant