Skip to content

Add 'Good First Issue' label to reasons an issue doesn't go stale #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjlittle merged 3 commits into from
Sep 15, 2021
Merged

Add 'Good First Issue' label to reasons an issue doesn't go stale #4317

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07bca79
Add 'Good First Issue' label to reasons an issue can be exempt from g…
Sep 15, 2021
7193fc1
Revert unintentional change to loading_iris_cubes.rst
Sep 15, 2021
cde6a80
Updated whats new
Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ jobs:

# Labels on issues exempted from stale.
exempt-issue-labels: |
"Status: Blocked,Status: Decision Required,Peloton 🚴‍♂️"
"Status: Blocked,Status: Decision Required,Peloton 🚴‍♂️,Good First Issue"

# Labels on prs exempted from stale.
exempt-pr-labels: |
"Status: Blocked,Status: Decision Required,Peloton 🚴‍♂️"
"Status: Blocked,Status: Decision Required,Peloton 🚴‍♂️,Good First Issue"

# Max number of operations per run.
operations-per-run: 300
Expand Down
8 changes: 8 additions & 0 deletions docs/src/userguide/loading_iris_cubes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,14 @@ constraint to ``load``::
level_10 = iris.Constraint(model_level_number=10)
cubes = iris.load(filename, forecast_6 & level_10)

.. note::

Whilst ``&`` is supported, the ``|`` that might reasonably be expected
is not. This is because "or" constraints could lead to a cube which did
not cover a hyper-rectangular region if these constraints were on
different coordinates. If an "or" type constraint on a single coordinate
is useful then it may be obtained by passing a function to :class:`iris.Constraint`.
Copy link
Member

@bjlittle bjlittle Sep 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjbenfold Lovely contribution, thanks, but let's separate concerns here.

I'd prefer that you removed this update to the docs from this PR and include it in a separate PR.

Is that okay?

Copy link
Contributor Author

@wjbenfold wjbenfold Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't think I'd added this file and I can't see from my command history how it got in here. I'll remove it


As well as being able to combine constraints using ``&``,
the :class:`iris.Constraint` class can accept multiple arguments,
and a list of values can be given to constrain a coordinate to one of
Expand Down