Add 'Good First Issue' label to reasons an issue doesn't go stale #4317
Conversation
|
I'm currently unsure as to how to test this, because I can't force a github issue to go stale. I could resurrect an issue and tag it as "Good First Issue" then see if the next run of the stale bot makes it stale, but not sure that can be done outside of production? @bjlittle |
|
@wjbenfold I'm happy to merge "as is" and observe the subsequent GHA behaviour without specifically testing this change, so that's fine 👍 |
There was a problem hiding this comment.
@wjbenfold Awesome, thanks 👍
Could you also add a whatsnew entry in the documentation to cover this? I guess we could categorise it under the Internal section.
Also, there is just one comment to service, then we'll get this contribution banked 😄
| .. note:: | ||
|
|
||
| Whilst ``&`` is supported, the ``|`` that might reasonably be expected | ||
| is not. This is because "or" constraints could lead to a cube which did | ||
| not cover a hyper-rectangular region if these constraints were on | ||
| different coordinates. If an "or" type constraint on a single coordinate | ||
| is useful then it may be obtained by passing a function to :class:`iris.Constraint`. |
There was a problem hiding this comment.
@wjbenfold Lovely contribution, thanks, but let's separate concerns here.
I'd prefer that you removed this update to the docs from this PR and include it in a separate PR.
Is that okay?
There was a problem hiding this comment.
Huh, I didn't think I'd added this file and I can't see from my command history how it got in here. I'll remove it
* main: (71 commits) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) Updated environment lockfiles (SciTools#4289) Update cube.py (SciTools#4287) Integrated whatsnew for v3.1 release (rc0) (SciTools#4285) Version changes and final whatsnew tweaks for 3v1rc0. (SciTools#4284) Missing whatsnew entries for 3.1 release. (SciTools#4283) Update CF standard name table to v77 (SciTools#4282) ...
* main: (94 commits) added support for make html-noapi and html-quick for the docs build (SciTools#4333) Refactor some netcdf save code (SciTools#4301) [pre-commit.ci] pre-commit autoupdate (SciTools#4329) Update to loading docs to cover absence of 'or' for constraints (SciTools#4321) update latest.rst.template (SciTools#4323) stable cartopy feature download (SciTools#4328) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) ...
2 participants
🚀 Pull Request
Description
Added "Good First Issue" to the exempt list for both exempt-issue-labels and exempt-pr-labels so that these won't be made stale.
Based on a suggestion by @trexfeathers in Peloton today, stopping good first issues from going stale means that there's a supply of them for new developers to get involved through (particularly as there aren't a huge number of them).
Consult Iris pull request check list