Skip to content

Conversation

@pelson
Copy link
Member

@pelson pelson commented Jun 25, 2017

I mostly worked off of e45acf7#diff-319dea6a401e00cbfd00d1aa0969c6a4 to figure out what was still using iris.fileformats.grib.

I've not touched tools/translator and tools/gen_translations.py as I'm not certain how much of that has moved over to iris_grib.

@pelson
Copy link
Member Author

pelson commented Jun 25, 2017

I haven't touched lib/iris/tests/integration/format_interop/test_name_grib.py - we need to do some more work to remove the full integration testing from iris-core.

@pelson
Copy link
Member Author

pelson commented Jun 25, 2017

Some of the docs talk about iris.fileformats.grib.as_pairs - it's not clear to me what the deprecation path was in our previous release wrt. this. Some more detail on the docs will be needed (as a follow-up to this PR).

@pelson
Copy link
Member Author

pelson commented Jun 25, 2017

Lots of tests timing out (as per #2618). One peculiar failure that I'm not able to reproduce locally:

======================================================================
FAIL: test_pep8_conformance (iris.tests.test_coding_standards.TestCodeFormat)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test-environment/lib/python2.7/site-packages/Iris-2.0.0.dev0-py2.7-linux-x86_64.egg/iris/tests/test_coding_standards.py", line 215, in test_pep8_conformance
    '{}'.format('\n  '.join(unexpectedly_good)))
AssertionError: Some exclude patterns were unnecessary as the files they pointed to either passed the PEP8 tests or do not point to a file:
  */src/conf.py
  */src/developers_guide/gitwash_dumper.py
-------------------- >> begin captured stdout << ---------------------
... stopped

@pelson
Copy link
Member Author

pelson commented Jun 25, 2017

FWIW: SciTools/iris-grib#82 ports the iris.fileformats.grib functionality to iris_grib.

@pelson pelson mentioned this pull request Oct 18, 2017
pp-mo added a commit to pp-mo/iris that referenced this pull request Oct 25, 2017
@pelson
Copy link
Member Author

pelson commented Oct 26, 2017

Merged in #2810

@pelson pelson closed this Oct 26, 2017
@pelson pelson deleted the grib_begone branch October 26, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant