-
Notifications
You must be signed in to change notification settings - Fork 44
Port the changes from iris.fileformats.grib back into iris_grib. #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note: I accidentally pushed this branch to scitools/iris-grib, rather than my own fork. Apologies for that. |
Fix translation generator tool to use internal grib module.
|
For the record, the pertinent commit in Iris that brought iris_grib back in was: SciTools/iris@e45acf7#diff-3967991fd23406c94b677376dc007fd8 |
| __slots__ = ('shape', 'dtype', 'fill_value', 'recreate_raw') | ||
| __slots__ = ('shape', 'dtype', 'recreate_raw') | ||
|
|
||
| def __init__(self, shape, dtype, fill_value, recreate_raw): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an oversight in iris.
You have been shown this before but in case you forgot, there was an attempt to open the discussion about the future of iris_grib on the goole groups. I don't understand the purpose of this PR. As far as I'm concerned iris_grib is dead |
|
Thanks @lbdreyer. The link was helpful - I've written something there, and suggested we get together to discuss iris' direction in a slightly higher-bandwidth form. (doodle poll for date/time: https://doodle.com/poll/yaxm4pqfkus96sm2) Suffice to say, I personally do not feel that the subject has been considered sufficiently to call iris-grib a dodo just yet... |
|
The thread was: https://groups.google.com/forum/#!topic/scitools-iris-dev/lFw2_CnaEHU In light of this, could this please get a review? @SciTools/iris-grib-devs |
|
I'm happy that this is equivalent to code in Iris at "version 2.0a0", i.e. SciTools/iris@7ec22fa. Note that this version only works with current iris master branch, at the "2.0a0" version (which is not a tag, to avoid problems with conda-forge : see above SHA for reference). |
I've done this with very little understanding of the original rationale for integrating iris_grib back into iris, so I may have missed a key detail.