Skip to content

Corrected use of deprecated numpy behaviour. Necessary for numpy 1.12 #2551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbdreyer merged 1 commit into from
May 16, 2017
Merged

Corrected use of deprecated numpy behaviour. Necessary for numpy 1.12 #2551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/iris/fileformats/grib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def __init__(self, grib_message, grib_fh=None, auto_regularise=True):
# The byte offset requires to be reset back to the first byte
# of this message. The file pointer offset is always at the end
# of the current message due to the grib-api reading the message.
proxy = GribDataProxy(shape, np.zeros(0).dtype, np.nan,
proxy = GribDataProxy(shape, np.array([0.]).dtype, np.nan,
Copy link
Member

@lbdreyer lbdreyer May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't understand why this needs to be done rather than np.float_ (as suggested in this comment). Surely it just needs a float datatype?

Copy link
Member

@corinnebosley corinnebosley May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I spoke to Dan about this he suggested that this is because at some point in the future, numpy might mess about with np.float as a datatype, so this method is more robust.

grib_fh.name,
offset - message_length,
auto_regularise)
Expand Down