Corrected use of deprecated numpy behaviour. Necessary for numpy 1.12 #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
reviewed
May 16, 2017
| # of this message. The file pointer offset is always at the end | ||
| # of the current message due to the grib-api reading the message. | ||
| proxy = GribDataProxy(shape, np.zeros(0).dtype, np.nan, | ||
| proxy = GribDataProxy(shape, np.array([0.]).dtype, np.nan, |
Member
There was a problem hiding this comment.
I still don't understand why this needs to be done rather than np.float_ (as suggested in this comment). Surely it just needs a float datatype?
Member
There was a problem hiding this comment.
When I spoke to Dan about this he suggested that this is because at some point in the future, numpy might mess about with np.float as a datatype, so this method is more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed replacement for #2468
targeting master for the 1.13 release