image hash work around #2196
Merged
image hash work around #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bjlittle it's not pretty, but it may be better than nothing for now |
bjlittle
reviewed
Oct 14, 2016
| figure.savefig(result_fname) | ||
| def save_figure_hash(): | ||
| figure = plt.gcf() | ||
| figure.savefig(result_fname) |
Member
Member
Author
There was a problem hiding this comment.
I don't think this is a cosmetic change
previously the figure = plt.gcf() and figure.savefig(result_fname) were in the code, a little way apart.
i moved them together, without changing either line
minor point tho
Member
Member
|
@marqh Unfortunately, I don't see this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
temporary work around for unknown and occasional non-repeatable check_graphic test failure
if it fails, try again, mostly it works second time round
masks #2195 does not fix it