Check graphic create missing #2192
Conversation
| lock = filelock.FileLock(fname) | ||
| # The imagerepo.json file is a critical resource, so ensure thread | ||
| # safe read/write behaviour via platform independent file locking. | ||
| with lock.acquire(timeout=600): |
There was a problem hiding this comment.
@marqh A suitably high timeout ...
Having the graphics tests fighting over the imagerepo.lock doesn't seem to impact the overall running time of the tests in travis ... but it's hard to tell due to the variable loads on travis.
I don't think this is a problem, but we could choose to only acquire a lock if the IRIS_TEST_CREATE_MISSING environment variable is set - as this means there could be potential writing to the imagerepo.json.
In travis the IRIS_TEST_CREATE_MISSING environment variable should never be set. So there is the opportunity to avoid any potential lock contention overhead that may be incurred.
My expectation is that the IRIS_TEST_CREATE_MISSING environment variable will only be set by the developer on their desktop when needed.
|
This PR requires some extra work ... in-bound |
bjlittle
added
on hold
Status: Work in Progress
and removed
Status: Work in Progress
on hold
labels
|
@marqh Ping ... |
|
@marqh LGTM |
bjlittle
force-pushed
the
check-graphic-create-missing
branch
from
39db672 to
915be32
Compare
|
@marqh Rebased and good to go ... |
|
thanks @bjlittle |
2 participants
The missing part of the new image test work-flow, to allow developers to create missing/new image test expected result files and associated entries in the
imagerepo.jsonfile.