Conversation
trexfeathers
commented
Jul 11, 2022
Contributor
Author
|
I think the test failure may be due to upstream Iris changes. Will look tomorrow. |
Contributor
Author
|
I expect these mappings are all fine. To avoid staleness I propose reviewing and merging at the end of September. |
Contributor
Author
|
Julian has approved this as working for their tests 👍 |
Contributor
Author
|
Needs #299 to fix the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked: SciTools/iris#4859 - Julian Heming is aiming for some additional GRIB-to-PP mappings.
Checking Julian's suggestions against the WMO Codes Registry allowed me to get a
long_namefor these new mappings, which I see isn't usually done. Hopefully that's not a breaking addition.This is fresh territory for me so I'm not 100% confident. Please can the reviewer be vigilant!
I also need Julian's eyes on this before merging. I don't think he's on GitHub but I will be contacting personally.