Skip to content

Conversation

@trexfeathers
Copy link
Contributor

This PR:

As discussed offline with @pp-mo, my conflicting time commitments have stopped me testing this, so we have agreed that testing can be part of a more thorough review process before it's appropriate to be merged.

@trexfeathers trexfeathers requested a review from pp-mo September 30, 2020 11:18
@trexfeathers
Copy link
Contributor Author

@pp-mo not planning to do any more work on this. Please take a look and see how we can get the tests working!

I also haven't looked too closely about whether the pip set up is OK. One question that springs to mind is whether wheel should be part of requirements/setup.txt.

@pp-mo
Copy link
Member

pp-mo commented Oct 6, 2020

Replaced by #231 : on new feature-branch
( Most of the code there is actually derived from this. )

@pp-mo pp-mo closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants