Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented May 29, 2018

WIP
Test have been failing since it tests against iris-master, but was also relying on "iris/minimal-conda-requirements.txt", which is now defunct.
We "ought" to be testing against the latest Iris release, not master, in any case.
I think this was not doing so as it predated our first usable Iris 2 release.

Hopefully we now have a usable Iris v2 on conda-forge, so we should now test against that.

@DPeterK
Copy link
Member

DPeterK commented May 29, 2018

@pp-mo the code changes look ideal (though, as discussed offline, we'll probably need to add more packages to the install list) and we've moved the testing error onto a failure at least, so things are looking up! 🙄

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.689% when pulling 068ad78 on pp-mo:use_iris_release into 69f4fa3 on SciTools:master.

@pp-mo
Copy link
Member Author

pp-mo commented May 29, 2018

looking up 🙄

Well it now passes !

I think this is "close", but there are some irritating dependency problems which here I'm working around with some pins ...

All this should get fixed in Iris 2.1, so I think we can wait for that rather than trying to reinvent the wheel

@DPeterK
Copy link
Member

DPeterK commented May 30, 2018

@pp-mo nice work - this looks fine (and the tests are passing! 💯) Need to remember to treat this as an intermediary and unpin when Iris 2.1 is released, but there's no point in reinventing the wheel, as you said.

@DPeterK DPeterK merged commit ebd5ad6 into SciTools:master May 30, 2018
@pp-mo pp-mo deleted the use_iris_release branch June 16, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants