Extend regridder saving/loading to all regridders#357
Merged
pp-mo merged 11 commits intoSciTools:mainfrom May 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
+ Coverage 98.85% 98.92% +0.07%
==========================================
Files 37 37
Lines 3929 4196 +267
==========================================
+ Hits 3884 4151 +267
Misses 45 45 ☔ View full report in Codecov by Sentry. |
* main: Move benchmark code from nox to bm_runner (SciTools#361) Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools#356) Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools#355) [pre-commit.ci] pre-commit autoupdate (SciTools#336) Updated environment lockfiles (SciTools#344)
pp-mo
requested changes
May 30, 2024
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
I'm not really competent to comment on all the mechanics here.
But I have raised some 'style' points, including docstrings that seem to need changing.
Also, I think it probably needs a changelog entry ?
* main: Ensure dtype is preserved after regridding (SciTools#239)
pp-mo
approved these changes
May 30, 2024
Member
|
OK I think this is all good now |
stephenworsley
added a commit
to stephenworsley/iris-esmf-regrid
that referenced
this pull request
Jul 18, 2024
* main: Bump scitools/workflows from 2024.06.0 to 2024.06.5 (SciTools#377) Fix typo (SciTools#371) Bump scitools/workflows from 2024.04.3 to 2024.06.0 (SciTools#365) Update to v0.11.dev0. (SciTools#363) Update to v0.10.0 (SciTools#362) Extend regridder saving/loading to all regridders (SciTools#357) Ensure dtype is preserved after regridding (SciTools#239) Move benchmark code from nox to bm_runner (SciTools#361) # Conflicts: # esmf_regrid/schemes.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318