Skip to content

Ensure dtype is preserved after regridding#239

Merged
pp-mo merged 12 commits intoSciTools:mainfrom
stephenworsley:dtype_fix
May 29, 2024
Merged

Ensure dtype is preserved after regridding#239
pp-mo merged 12 commits intoSciTools:mainfrom
stephenworsley:dtype_fix

Conversation

@stephenworsley
Copy link
Copy Markdown
Contributor

@stephenworsley stephenworsley commented Feb 22, 2023

Adresses #238.

@stephenworsley
Copy link
Copy Markdown
Contributor Author

stephenworsley commented Feb 22, 2023

Note: this will still change the dtype if you start with integer data (by design). This does mean that the dask array also will have to be changed to better align with the underlying data in this case. This should be a seperable issue which can be addressed in its own PR.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.85%. Comparing base (a50b2b8) to head (b587641).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
esmf_regrid/schemes.py 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   98.85%   98.85%   -0.01%     
==========================================
  Files          36       37       +1     
  Lines        3855     3929      +74     
==========================================
+ Hits         3811     3884      +73     
- Misses         44       45       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pp-mo
pp-mo requested changes Feb 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that there aren't a few more cases to address here. I think I would create test examples where both weights + source_array can be integer / float32 / float64, and check that output dtypes are as expected in all those cases.
But I may have missed that dtypes for the weights array are always known, or more limited ?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 29, 2023

@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label May 29, 2023
@stephenworsley stephenworsley removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label May 30, 2023
@trexfeathers trexfeathers linked an issue Jun 21, 2023 that may be closed by this pull request
dtype of regridded cube changes after realizing the data #238
Closed
@trexfeathers trexfeathers assigned HGWright and unassigned pp-mo Sep 20, 2023
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 26, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Dec 21, 2023
Open
Merged
@pp-mo pp-mo assigned pp-mo and unassigned HGWright Mar 20, 2024
stephenworsley and others added 5 commits April 25, 2024 15:13
@stephenworsley
Merge branch 'main' into dtype_fix
909a5c0 
* main: (42 commits)
  Update lockfiles and fix for new esmpy (SciTools#342)
  Fix for esmpy (SciTools#353)
  Fix usage of map_blocks (SciTools#338)
  Revert "Updated environment lockfiles (SciTools#335)" (SciTools#341)
  Updated environment lockfiles (SciTools#335)
  Bump actions/cache from 3 to 4 (SciTools#333)
  Bump actions/upload-artifact from 3 to 4 (SciTools#324)
  Bump actions/stale from 8.0.0 to 9.0.0 (SciTools#322)
  fix asv (SciTools#339)
  [pre-commit.ci] pre-commit autoupdate (SciTools#330)
  Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools#334)
  Updated environment lockfiles (SciTools#327)
  [pre-commit.ci] pre-commit autoupdate (SciTools#328)
  Updated environment lockfiles (SciTools#304)
  Add CITATION.cff (SciTools#319)
  updated for enums (SciTools#293)
  Flake8 compliant type checking. (SciTools#316)
  update to v0.10.dev0 (SciTools#314)
  Update to v0.9 (SciTools#313)
  First pass at mesh to mesh (SciTools#311)
  ...

# Conflicts:
#	CHANGELOG.md
#	esmf_regrid/esmf_regridder.py
#	esmf_regrid/schemes.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
20e5c7f 
for more information, see https://pre-commit.ci
@stephenworsley
fix dtype
74afda1
@stephenworsley
add tests
bfc457c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c2db0d2 
for more information, see https://pre-commit.ci
pp-mo
pp-mo requested changes Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically OK except for a possible tidy in the tests.

@stephenworsley
address review comments
e341ecf
@stephenworsley
Merge branch 'main' into dtype_fix
504d7ad 
* main:
  Move benchmark code from nox to bm_runner (SciTools#361)
  Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools#356)
  Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools#355)
  [pre-commit.ci] pre-commit autoupdate (SciTools#336)
  Updated environment lockfiles (SciTools#344)

# Conflicts:
#	CHANGELOG.md
@stephenworsley
flake 8 fix
b587641
@pp-mo pp-mo merged commit cf86c1d into SciTools:main May 29, 2024
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request May 30, 2024
@stephenworsley
Merge branch 'main' into generic_saving
ad1d24b 
* main:
  Ensure dtype is preserved after regridding (SciTools#239)
stephenworsley added a commit to stephenworsley/iris-esmf-regrid that referenced this pull request Jul 18, 2024
@stephenworsley
Merge branch 'main' into boundless_coords
1c12a90 
* main:
  Bump scitools/workflows from 2024.06.0 to 2024.06.5 (SciTools#377)
  Fix typo (SciTools#371)
  Bump scitools/workflows from 2024.04.3 to 2024.06.0 (SciTools#365)
  Update to v0.11.dev0. (SciTools#363)
  Update to v0.10.0 (SciTools#362)
  Extend regridder saving/loading to all regridders (SciTools#357)
  Ensure dtype is preserved after regridding (SciTools#239)
  Move benchmark code from nox to bm_runner (SciTools#361)

# Conflicts:
#	esmf_regrid/schemes.py
@trexfeathers trexfeathers mentioned this pull request Mar 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees

@pp-mo pp-mo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dtype of regridded cube changes after realizing the data

4 participants

@stephenworsley @CLAassistant @pp-mo @HGWright