Replace all references to Fixnum and Bignum with Integer (Fixnum and Bignum are deprecated) #604
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby2.4 unify Fixnum and Bignum into Integer https://bugs.ruby-lang.org/issues/12005
translunar
changed the title
translunar
approved these changes
Dec 20, 2017
| @@ -46,7 +46,7 @@ def to_nm(shape = nil, dtype = nil, stype = :dense) | |||
|
|
|||
| guess_dtype = ->(type) { | |||
| case type | |||
| when Fixnum then :int64 | |||
| when Integer then :int64 | |||
There was a problem hiding this comment.
This may present a problem further down the road. Bignum can store more than int64, and this method should probably check for overflow and be able to choose :object instead of :int64. I think the solution is probably to make :object the default dtype for Integer.
With that said, I'm not sure this is your job. It's a spec change. It needs additional consideration. I just wanted to mention it here.
|
There are some Travis-CI failures, but I believe they're entirely due to an rdoc incompatibility on Travis. I'm going to go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby2.4 unify Fixnum and Bignum into Integer
https://bugs.ruby-lang.org/issues/12005
ref translunar#22