Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed spec change: Integer should be treated as :object dtype rather than :int64 #605

Open
translunar opened this issue Dec 20, 2017 · 1 comment

Comments

@translunar
Copy link
Member

This issue follows from #604 (comment).

In the past, guess_dtype() would take a Fixnum and auto-assign a dtype of :int64. Now that Fixnum and Bignum are deprecated, an Integer may contain values that won't fit in :int64. Before we can release a new version, we need to adjust Integer to default to :object instead.

The other option (bad) would be to check each and every item in an array for :int64 overflow before allocating.

This raises the following question: do we even still want the :int64 dtype, or is it better to just use :object for anything that looks like an integer?

@translunar translunar modified the milestones: v0.2.5, v0.3.0 Dec 20, 2017
@translunar
Copy link
Member Author

I'm just revisiting this issue to note that using :object for integers will (a) speed up compilation, and (b) possibly make it easier for us to support faster element-wise math for float32, float64, and the complex dtypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant