Resolves #150: RSpec redesign #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Conversion to RSpec's `expect` syntax.
|
Here's an initial first pass at the RSpec redesign. I propose that #150 be broken up into multiple, smaller issues. We can go back and change the phrasing for many of the |
|
Had a glance through the diff, and this looks good to me for the syntax changes. Thanks for keeping the syntax conversion separate from the rephrasing; it's much easier to look at this way! |
|
Sweet. Thanks for the feedback! |
|
Yep, seems very good and Travis agrees. 👍 |
|
Great work. Thanks for the patch! |
|
Okay, merging now. Please disregard previous message (now deleted). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectsyntax.