-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec: spec re-design and cleanup #150
Comments
It seems this might be my first stab at open source contribution. :) |
Oh, excellent. I actually began the process in If you feel up to it, there might be some research to be done here too — what else could we be doing better with our specs? I know a lot of people swear by Cucumber. Pros and cons of using it? But this is really optional. The important thing is that the spec becomes more standardized (as outlined in the issue). Welcome! |
It seems a good way to get involved in the project. But I have to get to know a little about RSpec maybe. |
I've started work on the Here's some quick reading: http://betterspecs.org/#expect |
@duggiefresh I don't think the other contributors are keen on changing it given the number of NMatrix tests. I'm fine either way, tho. 👍 |
@duggiefresh This is a great guide. Go with the recommended practices from RSpec. Don't cling to our out-dated notions. =) |
@agarie This is actually the goal of this particular Issue. =) Changing things that are bad. |
Sweet. I hope to get the |
@MohawkJohn wonderful! @duggiefresh did you try using the transpec converter mentioned on that link? It might be easier to just convert everything and fix the remaining bugs. |
* Conversion to RSpec's `expect` syntax.
The one thing I really, really wish I'd done differently during design was to research RSpec a little more. It probably makes better sense to flip around all of the spec stuff so that instead of "NMatrix float64 should correctly invert your little sister," it does things like:
This requires a bit more design. But it probably doesn't require rewriting too many examples -- just rearranging stuff. Good way to get involved in the project and learn RSpec. =)
The text was updated successfully, but these errors were encountered: