Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Benchmarking Daru::Vector statistics methods #484

Closed
wants to merge 12 commits into from

Conversation

Shekharrajak
Copy link
Member

@Shekharrajak Shekharrajak commented Jan 22, 2019

@Shekharrajak
Copy link
Member Author

PR #483 will fix the travis error

value till 20 decimal places
@Shekharrajak
Copy link
Member Author

@v0dro
Copy link
Member

v0dro commented Jan 24, 2019

Good thought. However, I think we should move to benchmark-ips for the benchmarking: https://github.com/evanphx/benchmark-ips

It provides much more accurate benchmarks and the comparisons will not vary too much between machines.

@v0dro
Copy link
Member

v0dro commented Jan 24, 2019

Also, can you please use 2 spaces for all indentation in your code?

@Shekharrajak Shekharrajak changed the title Benchmarking Daru::Vector statistics methods [WIP] Benchmarking Daru::Vector statistics methods Jan 24, 2019
@Shekharrajak
Copy link
Member Author

Thanks @v0dro for suggestions, I have to refactor it and will use benchmark-ips .

@Shekharrajak
Copy link
Member Author

Shekharrajak commented Jan 25, 2019

I have compared various ways (using Array of array, array of vector, Hash of array , Hash of vector) of initializing Daru::DataFrame in this wiki page .

We can see that the fastest way is hash with list and list of Vector takes long time.

For initializing dataframe of 2 rows and 100 columns : 

Using Hash of lists:     8697.3 i/s
Using Hash of Vector:     3501.7 i/s - 2.48x  slower
 Using list of lists:     1228.0 i/s - 7.08x  slower
Using list of Vector:      379.6 i/s - 22.91x  slower

@v0dro v0dro closed this May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants