Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support bundler version 2.x.x #483

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

Shekharrajak
Copy link
Member

I got an error while using bundler 2.0 :

 ➜  bundle install
Fetching gem metadata from https://rubygems.org/...........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.10)

  Current Bundler version:
    bundler (2.0.1)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

Could not find gem 'bundler (~> 1.10)' in any of the relevant sources:
  the local ruby installation

@Shekharrajak
Copy link
Member Author

Ping @v0dro, please have a look into this PR. Otherwise, travis CI build will fail.

@Shekharrajak
Copy link
Member Author

We can see in Announcing page of bundler 2, mention that it has "Removed support for Ruby < 2.3". So the system which has bundler 2 installed already, will not be able to setup daru. Running bundle install will through this error :

For Ruby <= 2.2 :

Fetching: bundler-2.0.1.gem (100%)
ERROR:  Error installing bundler:
	The last version of bundler (>= 0) to support your Ruby & RubyGems was 1.17.3. Try installing it with `gem install bundler -v 1.17.3`
	bundler requires Ruby version >= 2.3.0. The current ruby version is 2.1.0.
The command "gem install bundler" failed and exited with 1 during .

For Ruby >= 2.3


Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.10)
  Current Bundler version:
    bundler (2.0.1)
This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

@@ -22,7 +22,10 @@ script:
- bundle exec yard-junk

install:
- gem install bundler
- if [ $TRAVIS_RUBY_VERSION == '2.2' ] || [ $TRAVIS_RUBY_VERSION == '2.1' ] || [ $TRAVIS_RUBY_VERSION == '2.0' ];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the daru-view travis file

@Shekharrajak
Copy link
Member Author

I will wait for 24 hours ( time for any other comments if someone has any other suggestions). Then I will go ahead and merge this.

@Shekharrajak Shekharrajak merged commit ff46974 into SciRuby:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant