html table code of DataFrame and Vector are modified #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@athityakumar use this in daru-io. |
|
Few things that can be useful in future (TODO):
|
Shekharrajak
added a commit
to Shekharrajak/daru
that referenced
this pull request
Sep 5, 2017
* table id is added in table html code * separating thead and tbody * methods for accessing thead and tbody * working tbody and thead script in datatables gem * modified some testcases * rubocop errors fixed * vector html table code modified and used thead and tbody tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be better if we use
theadandtbodytag in the html table code of the DataFrame and Vector . Also I have definedto_html_theadandto_html_tbodymethod to get the header and body part of the html table. These things will be helpful fordaru-viewtable ( generate table using DataTables gem ).See how I am using this PR branch in datatables example to generate table code with pagination, search and other features. . Actually DataTables gem will check the thead and tbody of the table.