Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #to_html method #62

Open
athityakumar opened this issue Sep 2, 2017 · 4 comments
Open

Add #to_html method #62

athityakumar opened this issue Sep 2, 2017 · 4 comments

Comments

@athityakumar
Copy link
Member

As per discussion on SciRuby/daru#405, I think it'd be apt for the the to_html to be added to daru-view rather than in daru or daru-io. Please mirror the changes caused by SciRuby/daru#366 here. 😄

However, if further discussions on the issue tracker end up in a different conclusion, feel free to close this issue. I'm temporarily closing SciRuby/daru-io#39.

@Shekharrajak
Copy link
Member

I think to_html must be in daru only.

@zverok
Copy link
Collaborator

zverok commented Sep 2, 2017

@Shekharrajak I am not sure it is true. What we are trying to do currently (see SciRuby/daru#405) is cleanup "core" daru of anything except its main purpose. It means, particularly, that:

  • all import/export goes to daru-io
  • everything related to iruby notebook goes, probably, to daru-view (well, it was not planned initially, but due to your hard efforts 👍, daru-view now targets iruby as well as web, right?..)

#to_html method has no generic value on itself, it is just "representation for iruby" thing, so, I believe Athitya has a point.

@Shekharrajak
Copy link
Member

Okay, So we must move the #to_html code and all the .erb files to daru-view .

Using Daru::View::Table.new(df, options={adapter: :googlecharts}).div returns the HTML and JS code for the df generated by adapter :googlecharts .

@zverok
Copy link
Collaborator

zverok commented Sep 2, 2017

Just don't hurry up with this task, it should be done only during process of creating daru 1.0 as per SciRuby/daru#405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants