Adds default order for Daru::DataFrame (issue #130) #329
Conversation
Rspec test added, has been written in the older format to main consistency. This will be easier to change while re-writing all tests to modern specifications file-wise. RDoc documentation has also been added.
lib/daru/dataframe.rb
Outdated
| @@ -2278,8 +2289,10 @@ def initialize_from_array source, vectors, index, opts | |||
|
|
|||
| case source.first | |||
| when Array | |||
| vectors = (0..source.size-1).to_a if vectors.nil? | |||
|
@zverok @v0dro - After closer inspection of the logs of the last successful build and current failing build of master branch in Travis CI, I observe that We can specify |
Instead of that, we can fix current rubocop version offences on each PR. They are reasonable, and being a small project we can't expect dedicated volunteers to "update rubocop" in separate PR. So whoever met new offences first is that unfortunate person who fixes them :) |
|
(but you can exclude Rakefile and Gemfile from rubocop-checked files, of course) |
|
@zverok - Alright, I'm taking one for the team. :) Rubocop offenses are fixed, and build is finally successful. It does feel good to see the |
| # | ||
| # # => | ||
| # # #<Daru::DataFrame: bat_man (4x2)> | ||
| # # 0 1 |
There was a problem hiding this comment.
Given your example, shouldn't [6,7,8,9] be the 1st vector?
There was a problem hiding this comment.
Thanks for pointing this out - fixed! 😄
There was a problem hiding this comment.
Didn't you use actual executed code for the example? Its better if you do that.
There was a problem hiding this comment.
I hadn't used the actual executed code in the initial commit (I had copy-pasted the previous rdoc example - my bad). I've added the output I get in the irb console while initializing the DataFrame given in the rdoc example, in the subsequent commit.
… argument empty Hash. (SciRuby#395)
Rspec test added, has been written in the older format to main consistency. This will be easier to change while re-writing all tests to modern specifications file-wise, rather than modernizing specs for individual functions. RDoc documentation has also been added.
Tackles issue #130