Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NMatrix instead of Matrix #1

Closed
agarie opened this issue Oct 6, 2014 · 2 comments
Closed

Use NMatrix instead of Matrix #1

agarie opened this issue Oct 6, 2014 · 2 comments

Comments

@agarie
Copy link
Member

agarie commented Oct 6, 2014

Hi Sameer, great job getting started on this problem.

However, one the benefits of having a "DataFrame-like" gem is to improve performance in several other libraries dependant on it simultaneously. So NMatrix is a better chance than the pure Ruby alternative, Matrix.

Other benefit of this approach is that you will probably uncover more bugs in NMatrix. :)

If you have any problems, please ask on the mailing list!
@v0dro
Copy link
Member

v0dro commented Oct 6, 2014

I am creating the gem such that one will able to create a dataframe from an Array, Hash, Matrix, NMatrix(MRI), or MDArray (JRuby).

You can see my latest push in the Vector class for seeing this in action.

Will that do?

@v0dro
Copy link
Member

v0dro commented Oct 6, 2014

Oh and anyway, the supplied Matrix object is converted to a flattened Array before storing.

@v0dro v0dro closed this as completed Oct 7, 2014
athityakumar added a commit to athityakumar/daru that referenced this issue Apr 7, 2017
@athityakumar
Tries resolving rubocop 0.48.1 release offenses - try SciRuby#1
8cf8265
v0dro pushed a commit that referenced this issue Apr 12, 2017
@athityakumar @v0dro
Adds default order for Daru::DataFrame (issue #130) (#329)
47d9da0 
* Adds default order for Daru::DataFrame

Rspec test added, has been written in the older format to main consistency. This will be easier to change while re-writing all tests to modern specifications file-wise. RDoc documentation has also been added.

* Refines code with ||=

* Tries resolving rubocop 0.48.1 release offenses - try #1

* Fixes Rdoc - example of Daru::DataFrame initialize without order
baarkerlounger added a commit to baarkerlounger/daru that referenced this issue Nov 7, 2017
@baarkerlounger @zatmonkey
API Readme (SciRuby#1)
ec34260 
* API Readme added to the main DB repo

* Images
@jonspalmer jonspalmer mentioned this issue May 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agarie @v0dro