-
Notifications
You must be signed in to change notification settings - Fork 33
fix: enable history table in datasets lifecycle tab #2066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/app/datasets/dataset-lifecycle/dataset-lifecycle.component.ts:69` </location>
<code_context>
const dataset = this.dataset;
</code_context>
<issue_to_address>
**suggestion (code-quality):** Prefer object destructuring when accessing and using properties. ([`use-object-destructuring`](https://docs.sourcery.ai/Reference/Rules-and-In-Line-Suggestions/TypeScript/Default-Rules/use-object-destructuring))
```suggestion
const {dataset} = this;
```
<br/><details><summary>Explanation</summary>Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.
From the [Airbnb Javascript Style Guide](https://airbnb.io/javascript/#destructuring--object)
</details>
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
minottic
reviewed
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of questions
src/app/datasets/dataset-lifecycle/dataset-lifecycle.component.spec.ts
Outdated
Show resolved
Hide resolved
Junjiequan
reviewed
Oct 17, 2025
src/app/datasets/dataset-lifecycle/dataset-lifecycle.component.ts
Outdated
Show resolved
Hide resolved
minottic
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the new backend did not implemet history[] in /v3/datasets, history was turned off / commented out in #2041. Uncommented and fixed type errors (some errors are automatically fixed by using the v4.24.5 of scicat-sdk-ts-angular which includes
ObsoleteDatasetOutputDto
with history field), as support for legacy history was added in SciCatProject/scicat-backend-next#2282Motivation
Fixes:
Changes:
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Screenshot
Summary by Sourcery
Enable dataset history in the lifecycle tab by updating the SDK version, adding a custom type for history properties, reactivating the parseHistoryItems method, and updating the corresponding unit test.
New Features:
Enhancements:
Tests: