feat: add numberOfDatasets in proposal table and the details page under general information #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
abdimo101
changed the title
Junjiequan
approved these changes
Oct 7, 2025
… the dataset schema
Junjiequan
force-pushed
the
add-numberofdatasets-proposal
branch
from
c1e620e to
a27d98f
Compare
5 tasks
omkar-ethz
added a commit
that referenced
this pull request
Oct 20, 2025
## Description As the new backend did not implemet history[] in /v3/datasets, history was turned off / commented out in #2041. Uncommented and fixed type errors (some errors are automatically fixed by using the v4.24.5 of scicat-sdk-ts-angular which includes `ObsoleteDatasetOutputDto` with history field), as support for legacy history was added in SciCatProject/scicat-backend-next#2282 ## Motivation ## Fixes: ## Changes: ## Tests included - [x] Included for each change/fix? - [x] Passing? (Merge will not be approved unless this is checked) ## Documentation - [ ] swagger documentation updated \[required\] - [ ] official documentation updated \[nice-to-have\] ### official documentation info If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included ## Backend version - [x] Does it require a specific version of the backend - which version of the backend is required: v4.24.5 ## Screenshot <img width="819" height="565" alt="history" src="https://github.com/user-attachments/assets/d06379a2-e137-4f70-a8eb-0367c49971bb" /> ## Summary by Sourcery Enable dataset history in the lifecycle tab by updating the SDK version, adding a custom type for history properties, reactivating the parseHistoryItems method, and updating the corresponding unit test. New Features: - Restore and display dataset history entries in the lifecycle tab Enhancements: - Upgrade scicat-sdk-ts-angular to v4.25.0 to include history in ObsoleteDatasetOutputDto - Add HistoryWithProperties type to support dynamic history fields in parsing logic Tests: - Un-comment and adapt the unit test for parseHistoryItems in DatasetLifecycleComponent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR displays the numberOfDataset field in proposal table & the proposal details page under general information.
Motivation
Background on use case, changes needed
Fixes:
Please provide a list of the fixes implemented in this PR
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
New Features: