fix: panic on completions #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b52da1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
thank you! 🙏 |
|
the failing tests do not seem related to this change. i'm not sure what additional steps i can take to get this merged. i looked for a way to retry the failed tests, but didn't see one. |
as far as i can tell, this was broken by the clap upgrade (Schniz#991).
quixoten
force-pushed
the
dc/fix-completions
branch
from
83139f3
to
8b52da1
Compare
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Aug 9, 2023
Patch applied for "fnm completions\ panic: Schniz/fnm#1010
|
Is this going to be merged anytime soon? |
|
It looks like the this PR is complete and good to be merged yes? |
Merged
|
Thanks for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1006. As far as i can tell, this was broken by the clap upgrade (#991).