#241 Group call notifications #250
Conversation
…LegacyQrCodeLogin Remove legacy qr code login
|
Thanks for your PR! I'll properly review and test when I have more time, maybe on the weekend. |
| when (intent?.getIntExtra(EXTRA_CALL_ACTION_KEY, 0)) { | ||
| CALL_ACTION_REJECT -> { | ||
| val callId = intent.getStringExtra(EXTRA_CALL_ID) ?: return | ||
| notificationUtils.cancelAllNotifications() |
There was a problem hiding this comment.
Should this really cancel all notifications?
There was a problem hiding this comment.
Yeap, this was for testing purpose. Fixed, here we should cancel certain notification
When I try to remove from "string.xml", I got "Unresolved reference: call_notification_open_app_action" while building the project. May be you can give example, how to correctly fix it |
| @@ -237,6 +237,9 @@ | |||
| <!-- SC-TMP, until merged upstream: https://github.com/vector-im/element-android/pull/5781 --> | |||
| <string name="settings_call_ringtone_use_default_stun_title">Allow fallback call assist server</string> | |||
| <string name="settings_call_ringtone_use_default_stun_summary">Will use %s as assist when your homeserver does not offer one (your IP address will be seen by the stun server during a call | |||
|
|
|||
| <string name="call_notification_open_app_action">Open App</string> | |||
| <string name="labs_enable_group_call_notifications_summary">Ring for group calls</string> | |||
| )</string> | |||
There was a problem hiding this comment.
You added the strings within another string, that's why the build can't find them - need to properly define them where they belong
There was a problem hiding this comment.
@SpiritCroc , just in case if that got slipped away unnoticed - strings has been adjusted
Please, let us know if any other obstacles or things to be adjusted / improved!
There was a problem hiding this comment.
I'm aware of that, thanks. The main thing I'm lacking right now is time to properly test and review, I assume earliest in two week. I usually don't do video calls on mobile, but until element-hq#8885 is fixed it's probably not too meaningful to get this released anyway.
There was a problem hiding this comment.
Thank you for a quick response and sharing what's on the plate.
We didn't have / tested video calls in mind as well - do you believe that issue 8885 is a blocker for audio calls as well?
This PR add ring for group jitsi calls. Also it includes corresponding lab feature, that enable/disable this functionality.