Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group calls to ring a bell on Android #241

Open
alexander-potemkin opened this issue May 26, 2024 · 6 comments
Open

Group calls to ring a bell on Android #241

alexander-potemkin opened this issue May 26, 2024 · 6 comments
Labels
upstream This issue is also applicable upstream

Comments

@alexander-potemkin
Copy link

Is your feature request related to a problem? Please describe.
Currently there is no way to become aware of the conference call that is happening on the room you are in.

Describe the solution you'd like
Use OS's default call ring mechanism to ring a bell when conf. call with Jitsi is happening. Like it's done on iOS Element's client.

Describe alternatives you've considered
I considered all I could, but, I believe, there is little could be done - custom notifications won't work on encrypted channels + it's not the same level of 'noiseness' as a call.

Additional context
From what I understood, Jitsi call is a special event (.im.vector.jitsi?) - it would be absolutely lovely for this event to raise the same level of noise, as a regular 1:1 call, as otherwise people keep missing group calls all of the time.

Thanks in advance for any considerations or thoughts sharing!

@SpiritCroc SpiritCroc added the upstream This issue is also applicable upstream label May 26, 2024
@alexander-potemkin
Copy link
Author

There is a pull request implementing this feature on Element Android.

I'm not sure how promptly it might be picked up - is there any chance it could be merged into SchildiChat directly?

@alexander-potemkin
Copy link
Author

@SpiritCroc , I'm not sure if you are the right person to tag - if not, and it's not too much to ask, may I ask you to introduce that person?

@SpiritCroc
Copy link
Member

If someone PRs it here in a upstream-merge-friendly way (e.g. I see some string changes in here which should go into strings_sc.xml, and some connectivity to upstream code which can be reduced), I may consider it. Though it's not a feature I'm personally interested in, so if it causes too many merge conflicts in the future I may want to drop it again.

@alexander-potemkin
Copy link
Author

@SpiritCroc , sure and thanks!
@Turubaev could you please, do the PR, addressing concerns raised above, so that the functionality in question would be comfortable to be maintained?

@Turubaev
Copy link

Turubaev commented Sep 9, 2024

#250

@alexander-potemkin
Copy link
Author

@SpiritCroc , as the PR has been pulled - please do let us know on anything that has to be adjusted (if anything, surely), so that you could accept this functionality comfortably.

I do understand the difficulties that might happen with maintaining functionality not in the upstream, and I would like to be sure that you are good with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream This issue is also applicable upstream
Projects
None yet
Development

No branches or pull requests

3 participants